New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow other aspects to follow HystrixCommandAspect #1684

Open
nmittler opened this Issue Sep 28, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@nmittler

nmittler commented Sep 28, 2017

The HystrixCommandAspect currently bypasses the ProceedingJoinPoint and invokes the method directly via MethodExecutionAction.

It could, however, be useful to support allowing an application to add an aspect that is run after the HysterixCommanAspect, on the execution thread of the service method.

From a quick look, it seems that two things would have to change (and local hacking shows that it works):

  1. HystrixCommandAspect will need to be given an @Order that is less than Integer.MAX_INT (the default). Something like @Order(Ordered.LOWEST_PRECEDENCE - 100) should be sufficient.
  2. HysterixCommandBuilderFactory could be modified to look for the JoinPoint provided in the MetaInfo. If it's there, a call could be made to joinPoint.proceed() rather than invoking the method.
@jabnih

This comment has been minimized.

jabnih commented Nov 23, 2018

I hope this feature could be support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment