Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codahale Metrics Filter configurable with Archaius #281

Merged
merged 3 commits into from Aug 27, 2014

Conversation

@SiIrving
Copy link
Contributor

SiIrving commented Jul 2, 2014

As discussed recently on the Hystrix OSS Mailing List, we have a requirement to filter the metrics published to Graphite via Codahale in a 'dynamically-configurable' fashion.

The neatest way to do this appeared to be to implement a CodaHale MetricsFilter with a reference to the Archaius DynamicPropertyFactory.

Thought I'd submit this pull request should the community feel it is useful

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Jul 2, 2014

Hystrix-pull-requests #139 SUCCESS
This pull request looks good

@benjchristensen

This comment has been minimized.

Copy link
Contributor

benjchristensen commented Aug 27, 2014

Thank you for submitting this.

Would an update to the README help others to know it exists and how to use it?

benjchristensen added a commit that referenced this pull request Aug 27, 2014
Codahale Metrics Filter configurable with Archaius
@benjchristensen benjchristensen merged commit af9ff7e into Netflix:master Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.