Add dynamic methods to tests explicitly to fix inconsistently failing tests #261

Merged
merged 1 commit into from Mar 5, 2013

Projects

None yet

3 participants

@claymccoy
Contributor

No description provided.

@cloudbees-pull-request-builder

asgard-pull-requests #9 SUCCESS
This pull request looks good

@claymccoy claymccoy merged commit ecea08d into Netflix:master Mar 5, 2013
@claymccoy claymccoy deleted the claymccoy:fixPullRequestBuild branch Mar 5, 2013
@jgritman

Why not put these calls in setup()?

Owner

Just because it's not needed (or wanted for all tests in the class). I guess it doesn't do anything as time consuming as parsing JSON files (today), but I still wanted to separate the methods that require it. A longer term fix would be to remove all Mocks calls from each method. The ones that can't be remove are integration tests that belong in the test environment. At that point I wouldn't have an issue with using Mocks methods in setup().

@jgritman
Contributor
jgritman commented Mar 5, 2013

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment