AbstractLatencyScoreStrategyImpl does not work as expected #239

Closed
guanig opened this Issue Mar 18, 2013 · 1 comment

Projects

None yet

2 participants

@guanig
guanig commented Mar 18, 2013

I'm trying to set up Cassandra ring with SmaLatencyScoreStrategyImpl and find out that AbstractLatencyScoreStrategyImpl does not work as expected.
in particular, method List<HostConnectionPool sortAndfilterPartition(List<HostConnectionPool> srcPools,
AtomicBoolean prioritized)
does:
Collections.sort(pools, scoreComparator); //for Step 1
..........
Collections.sort(pools, busyComparator); // for Step 2
..........
Step 3 then, expects pools to be sorted by Score, but they are sorted by busy after Step 2.

Could be fixed by change order for steps 2 and 3 or by adding another Collections.sort before Step 3.

@shyamalan shyamalan was assigned Apr 1, 2013
@shyamalan
Contributor

This has been fixed

@shyamalan shyamalan closed this Apr 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment