Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Re-introducing abstracting out of the version dependencies #264

Merged
merged 3 commits into from Apr 2, 2013

Conversation

Projects
None yet
2 participants
Contributor

shyamalan commented Apr 2, 2013

...ng out of the dependency versions, re-introducing the separate dependency-versions file to keep track of all version dependencies.

Fixing the previous build error properly so as to leverage the abstra…
…cting out of the dependency versions, re-introducing the separate dependency-versions file to keep track of all version dependencies.

@elandau elandau commented on the diff Apr 2, 2013

build.gradle
@@ -47,12 +48,14 @@ project(':astyanax') {
compile project(':astyanax-queue')
compile project(':astyanax-recipes')
compile project(':astyanax-entity-mapper')
+ compile project(':astyanax-examples')
@elandau

elandau Apr 2, 2013

Member

Let's keep this out. I don't think there's much value in packaging the examples with runtime jars.

@elandau elandau commented on the diff Apr 2, 2013

build.gradle
@@ -79,9 +82,9 @@ project(':astyanax-queue') {
project(':astyanax-cassandra') {
apply plugin: 'java'
dependencies {
- compile 'org.apache.cassandra:cassandra-all:1.2.2'
- compile 'org.jboss.netty:netty:3.2.4.Final'
- compile 'org.apache.servicemix.bundles:org.apache.servicemix.bundles.commons-csv:1.0-r706900_3'
+ compile "org.apache.cassandra:cassandra-all:$cassandraVersion"
@elandau

elandau Apr 2, 2013

Member

Fix indentation

elandau added a commit that referenced this pull request Apr 2, 2013

Merge pull request #264 from shyamalan/master
Re-introducing abstracting out of the version dependencies

@elandau elandau merged commit 935969d into Netflix:master Apr 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment