Reversed components in AbstractComposite types fail to parse on load #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnine
pushed a commit
to usergrid/usergrid
that referenced
this pull request
Feb 15, 2014
| @@ -364,7 +364,7 @@ private String getComparator(int i, ByteBuffer bb) { | |||
| byte a = (byte) (header & 0xFF); | |||
| name = aliasToComparatorMapping.get(a); | |||
| if (name == null) { | |||
| a = (byte) Character.toUpperCase((char) a); | |||
| a = (byte) Character.toLowerCase((char) a); | |||
There was a problem hiding this comment.
Transforming to the storage needs to call toUpperCase when reversed. As a result, we need to lower the value to determine it's comparator
|
@opuneet Bump. Any chance we can get this merged? |
|
@opuneet This is holding us up a bit in moving Usergrid (https://usergrid.incubator.apache.org/) off of Hector. No pressure though :) |
|
@opuneet Bump. Is this obsolete in the new 2.x releases ? |
|
@opuneet Sorry to flog a dead horse man, but this is holding up releasing Usergrid 2.0 to the public in Apache. Is there any way we can get this merged into the 1.2.x branch and released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an incorrect toLowerCase issue when utilizing reversed columns when parsing DynamicComposites from a ByteBuffer.