Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated logging in docker-compose #888

Merged
merged 1 commit into from Jan 10, 2019
Merged

Conversation

jwulf
Copy link
Contributor

@jwulf jwulf commented Dec 6, 2018

This patch reduces the amount of logs that get stored on the filesystem with the docker-compose. Running throughput tests on my local machine consumes gigs per minute without this.

@jwulf jwulf changed the title Restrict logging Truncated logging in docker-compose Dec 6, 2018
@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #888 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #888      +/-   ##
============================================
- Coverage     58.87%   58.85%   -0.02%     
  Complexity     2249     2249              
============================================
  Files           210      210              
  Lines         11191    11191              
  Branches       1045     1045              
============================================
- Hits           6589     6587       -2     
- Misses         4097     4099       +2     
  Partials        505      505
Impacted Files Coverage Δ Complexity Δ
...flix/conductor/core/execution/WorkflowSweeper.java 64.28% <0%> (-5.36%) 8% <0%> (ø)
...n/java/com/netflix/conductor/metrics/Monitors.java 73.33% <0%> (-2.23%) 33% <0%> (-1%)
...in/java/com/netflix/conductor/jedis/JedisMock.java 9.97% <0%> (-0.49%) 22% <0%> (ø)
.../com/netflix/conductor/grpc/server/GRPCServer.java 92.85% <0%> (+14.28%) 4% <0%> (ø) ⬇️
.../java/com/netflix/conductor/service/Lifecycle.java 60% <0%> (+30%) 3% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc44576...0f06a79. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2091

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 63.408%

Totals Coverage Status
Change from base Build 2048: 0.04%
Covered Lines: 7096
Relevant Lines: 11191

💛 - Coveralls

@cyzhao cyzhao merged commit 98f4e76 into Netflix:master Jan 10, 2019
long-64 pushed a commit to long-64/conductor that referenced this pull request Oct 2, 2019
Truncated logging in docker-compose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants