Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi query request #426

Merged
merged 13 commits into from
Jul 20, 2022
Merged

Conversation

manymotes
Copy link
Contributor

No description provided.

@manymotes
Copy link
Contributor Author

Our system would benefit from the ability to make multi operation requests. We have support e-commerce platforms. Reducing network calls/latency by combining many mutations and many queries would help us get our customers information more quickly. Side note, thank you for making DGS we love it.

Copy link
Contributor

@srinivasankavitha srinivasankavitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR contributions!


for (request in this.requests) {
val query = request.query
if (!query.getOperationType().equals(queryType) || queryType == OperationDefinition.Operation.SUBSCRIPTION.name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the check for SUBSCRIPTION doing in this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding of this, only one subscription is allowed per request. So I check to make sure they are not sending a subscription via the new GraphQLMultiQueryRequest object.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, that makes sense. Thanks for clarifying. Would be good to add that as a comment, if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed the comment. Great suggestion!

@srinivasankavitha srinivasankavitha merged commit 0c9f695 into Netflix:master Jul 20, 2022
@manymotes
Copy link
Contributor Author

TY @srinivasankavitha, really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants