-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi query request #426
Multi query request #426
Conversation
Our system would benefit from the ability to make multi operation requests. We have support e-commerce platforms. Reducing network calls/latency by combining many mutations and many queries would help us get our customers information more quickly. Side note, thank you for making DGS we love it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR contributions!
...ared-core/src/main/kotlin/com/netflix/graphql/dgs/client/codegen/GraphQLMultiQueryRequest.kt
Show resolved
Hide resolved
|
||
for (request in this.requests) { | ||
val query = request.query | ||
if (!query.getOperationType().equals(queryType) || queryType == OperationDefinition.Operation.SUBSCRIPTION.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the check for SUBSCRIPTION doing in this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understanding of this, only one subscription is allowed per request. So I check to make sure they are not sending a subscription via the new GraphQLMultiQueryRequest object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, that makes sense. Thanks for clarifying. Would be good to add that as a comment, if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed the comment. Great suggestion!
TY @srinivasankavitha, really appreciate it! |
No description provided.