feature: Allows fallback to Basic Auth in PKCE mode #4664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting a code review / pointers to documentation for requesting a code review – @whitdog47 @kevgliss @milavent |
|
This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 10 days. |
|
This PR was closed, because it has been stalled for 10 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
When using PKCE to facilitate authentication, owners and admins can still create username/password-based users if they choose to enable
DISPATCH_AUTH_REGISTRATION_ENABLED. These types of users make it much simpler to introduce API-based interactions.Presently, if a username/password-based user attempts to authenticate in a PKCE auth strategy, their supplied auth token lacks the necessary properties to fulfill the token & erroneously fails.
Changes
This introduces a simple fallback check to see if the supplied token fulfills PKCE needs. If it doesn't, it falls back to Basic Auth.