Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak EurekaClientConfig interface compat #1317

Merged
merged 1 commit into from Jun 29, 2020
Merged

Unbreak EurekaClientConfig interface compat #1317

merged 1 commit into from Jun 29, 2020

Conversation

troshko111
Copy link
Contributor

EurekaClientConfig is treated as stable backward-compat API as of couple of years ago, update it to preserve backward-compat.

@troshko111
Copy link
Contributor Author

This un-does breaking contract change introduced by 6438fba

@tauparticle
Copy link

LGTM

@osi
Copy link

osi commented Jun 29, 2020

thanks for the quick fix!

@troshko111 troshko111 merged commit ef87b44 into master Jun 29, 2020
@troshko111 troshko111 deleted the troshko/compat branch June 29, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twicksell twicksell Awaiting requested review from twicksell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@troshko111 @tauparticle @osi