Fix transpilation error to support React Native #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarle
force-pushed
the
react-native-babel
branch
from
5d57e1e
to
30d913a
Compare
Recent versions of Babel will throw a TransformError in certain runtimes if any property on `Symbol` is assigned a value. This fixes the issue, which is the last remaining issue for React Native support.
clarle
force-pushed
the
react-native-babel
branch
from
30d913a
to
d086602
Compare
|
Looks fine to me if it gets us by Babel. All the native symbols (iterator, match, etc.) seem to be "writable:false" natively. It seems to be heavy handed with Will give Jafar a little to comment, otherwise will merge later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of Babel will throw a TransformError in certain runtimes if any property on
Symbolis assigned a value using dot notation, which includes React Native. This makes sense, since you probably don't want to be assigning values on top of existing symbols anyway in environments that already support them.This retains the same polyfilling behavior for platforms without
Symbol.forandSymbol.observable, but lets Babel properly transpile.With the change to Falcor to support Promise shimming merged in, this is the last remaining issue needed to support React Native in 1.x. Fixes #603.
@jhusain @sdesai @ktrott