Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Primalize gem for performance comparison #42

Closed
wants to merge 2 commits into from

Conversation

jgaskins
Copy link

@jgaskins jgaskins commented Feb 3, 2018

Primalize has different opinions about structure than the JSON API, so the output isn't the same, but I thought it might be useful to have another performance datapoint.

I just noticed I left some debugging output in there. I'll remove it if you're interested in merging.

@grossadamm
Copy link
Contributor

@jgaskins right now we are focused on just the json api spec. It is an interesting comparison, but I'm not sure if it makes sense to have right now. If we open this gem up to be more flexible, it would definitely make sense.

@jgaskins
Copy link
Author

jgaskins commented Feb 7, 2018

No worries, this is good to know. I wasn't sure if this gem was more focused on the "fast" part or the "JSONAPI" part. :-)

If there were a JSONAPI adapter for Primalize, would that be a more helpful performance datapoint?

@jgaskins jgaskins closed this Feb 7, 2018
@jgaskins jgaskins reopened this Feb 10, 2018
@jgaskins
Copy link
Author

I had some spare time to hammer out a JSONAPI adapter for Primalize. This gem is still quite a bit faster, but it appears both are miles ahead of AMS. From my local test runs:

Serialize to JSON string 1000 with includes and meta

Serializer Records Time
AMS serializer 1000 314.78
Fast serializer 1000 12.78
Primalize 1000 25.21

@jgaskins jgaskins changed the title Add Primalize gem for performance comparison, too Add Primalize gem for performance comparison Feb 11, 2018
@shishirmk
Copy link
Collaborator

I think we have so many comparisons already. I am not sure if more comparisons will add any value. So I am going to close this. Thank you for the pull request

@shishirmk shishirmk closed this Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants