Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClusterChecker metrics for remote healthchecks #869

Merged
merged 2 commits into from May 13, 2019

Conversation

Projects
None yet
3 participants
@mprimi
Copy link
Contributor

commented May 11, 2019

No description provided.

mprimi added some commits May 10, 2019

Update ClusterCheckerTask list of ignored health indicators
Remove deprecated indicator 'memory' and 'discoveryComposite'.
Ignore indicators 'mail' and 'genieAgent'.
Add additional metrics to ClusterCheckerTask
Publish each remote healthcheck indicator status to aid debugging of failing ones.

@mprimi mprimi requested a review from tgianos May 11, 2019

@mprimi mprimi self-assigned this May 11, 2019

@mprimi mprimi added the Improvement label May 11, 2019

@mprimi mprimi added this to the 4.0.0 milestone May 11, 2019

@codecov

This comment has been minimized.

Copy link

commented May 11, 2019

Codecov Report

Merging #869 into master will decrease coverage by 0.06%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #869      +/-   ##
============================================
- Coverage     88.55%   88.49%   -0.07%     
+ Complexity     3175     3174       -1     
============================================
  Files           393      393              
  Lines         12704    12722      +18     
  Branches        867      869       +2     
============================================
+ Hits          11250    11258       +8     
- Misses         1066     1073       +7     
- Partials        388      391       +3
Impacted Files Coverage Δ Complexity Δ
...genie/web/properties/ClusterCheckerProperties.java 100% <100%> (ø) 7 <1> (ø) ⬇️
...lix/genie/web/tasks/leader/ClusterCheckerTask.java 87.87% <76.92%> (-4.72%) 21 <0> (ø)
...t/web/configs/IntegrationTestingConfiguration.java 50% <0%> (-16.67%) 3% <0%> (ø)
...vices/loadbalancers/script/ScriptLoadBalancer.java 79.62% <0%> (-1.86%) 9% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ef137...d0a3c28. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

commented May 11, 2019

Coverage Status

Coverage decreased (-0.02%) to 91.574% when pulling d0a3c28 on mprimi:master into f7ef137 on Netflix:master.

@@ -406,7 +406,7 @@ determined by Zookeeper or other mechanism via Spring
|genie.tasks.cluster-checker.healthIndicatorsToIgnore
|The health indicator groups from the actuator /health endpoint to ignore when determining if a node is lost or not as
a comma separated list
|memory,genieMemory,discoveryComposite
|genieMemory,mail,genieAgent

This comment has been minimized.

Copy link
@tgianos

tgianos May 13, 2019

Contributor

Just an FYI that this list may be different internally or set to a different property at least. Probably will want to double check before pushing

@mprimi mprimi merged commit 2a666cb into Netflix:master May 13, 2019

1 of 4 checks passed

codecov/patch 77.77% of diff hit (target 88.55%)
Details
codecov/project 88.49% (-0.07%) compared to f7ef137
Details
coverage/coveralls Coverage decreased (-0.02%) to 91.574%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.