Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for deleted records being inserted into the write state as Object #188

Merged
merged 3 commits into from Mar 29, 2018

Conversation

@duro1
Copy link
Contributor

commented Mar 22, 2018

This caused a restore operation to fail with "java.lang.IllegalStateException: When state engine was restored, not all necessary states were present! Unrestored states: [Object]"

Used static DELETE_RECORD object from HollowIncrementalCyclePopulator when adding items to be deleted to the mutations collection
Removed misleading DELETE_RECORD from HollowIncrementalProducer

Chad.Durovec added 3 commits Mar 22, 2018
Chad.Durovec
Bug fix for deleted records being inserted into the write state as Ob…
…ject

This caused a restore operation to fail with "java.lang.IllegalStateException: When state engine was restored, not all necessary states were present!  Unrestored states: [Object]"

Used static DELETE_RECORD object from HollowIncrementalCyclePopulator when adding items to be deleted to the mutations collection
Removed misleading DELETE_RECORD from HollowIncrementalProducer
Chad.Durovec
Chad.Durovec
@duro1

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2018

@toolbear Please take a look at this bugfix for an issue that was introduced with release v2.9.9

FYI: @rpalcolea @tinetti

@rpalcolea
Copy link
Member

left a comment

LGTM

@duro1

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2018

@toolbear @dkoszewnik @akhaku Can I get a merge?

@akhaku akhaku merged commit 5b0295a into Netflix:master Mar 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akhaku

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2018

Thanks!

@duro1

This comment has been minimized.

Copy link
Contributor Author

commented Mar 30, 2018

@akhaku Thanks for the PR! Do you think these changes could be included in a patch release soon?

@akhaku

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2018

Absolutely - planning on doing a release of this and #189 some time today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.