Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox compatibility #16

Merged
merged 4 commits into from Jan 17, 2017
Merged

Firefox compatibility #16

merged 4 commits into from Jan 17, 2017

Conversation

vaxvms
Copy link
Contributor

@vaxvms vaxvms commented Jan 16, 2017

Theses patchs make inviso web-ui working under firefox

@danielcweeks
Copy link
Contributor

Thanks @vaxvms. Unfortunately, I believe this also causes it to stop working on Chrome. It looks like window.event.pageX and elem.pageX are not handled the same across browsers.

Took a quick look and it appears that d3.event.pageX might abstract this and work with both.

Would you be willing to resubmit with those changes? Thanks!

@danielcweeks danielcweeks merged commit 5f7a92e into Netflix:master Jan 17, 2017
@danielcweeks
Copy link
Contributor

Thanks @vaxvms!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants