Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker registry parsing for AWS Batch decorator #62

Merged
merged 1 commit into from Dec 16, 2019
Merged

Conversation

@savingoyal
Copy link
Member

savingoyal commented Dec 16, 2019

re.search instead of re.match to disambiguate between valid docker
registry urls

re.search instead of re.match to disambiguate between valid docker
registry urls
Copy link
Contributor

romain-intel left a comment

LGTM

@savingoyal savingoyal merged commit 80e4546 into master Dec 16, 2019
2 checks passed
2 checks passed
Test on ubuntu-latest
Details
Test on macos-latest
Details
@savingoyal savingoyal deleted the docker branch Dec 19, 2019
@savingoyal

This comment has been minimized.

Copy link
Member Author

savingoyal commented Dec 21, 2019

@Shago7939 Could you elaborate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.