Add Python interpreter to execution PATH for AWS Batch #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
force-pushed
the
conda-path-for-aws-batch
branch
from
d579478
to
f5b3b63
Compare
This is needed to ensure non-pythonic conda dependencies are visible to the user code on AWS Batch
savingoyal
force-pushed
the
conda-path-for-aws-batch
branch
from
1599e3c
to
f5c090f
Compare
| # Add the Python interpreter's parent to the path. This is to | ||
| # ensure that any non-pythonic dependencies introduced by the conda | ||
| # environment are visible to the user code. | ||
| env_path = os.path.dirname(sys.executable) |
There was a problem hiding this comment.
Can this have unintended consequences in a non Conda env? I don't think so but checking.
There was a problem hiding this comment.
This shouldn't since the effect is isolated to an individual task.
| @@ -305,11 +313,7 @@ def runtime_step_cli(self, | |||
| if self.addl_paths is not None: | |||
| addl_paths = os.pathsep.join(self.addl_paths) | |||
| python_path = os.pathsep.join([addl_paths, python_path]) | |||
There was a problem hiding this comment.
So here we are assuming that PATH will be updated later in task_pre_step, correct? Why not just remove the restriction on batch?
There was a problem hiding this comment.
Correct. Just removing the restriction on batch won't work since we need to set the environment during task execution and this hook executes pre-task execution.
|
@romain-intel Good to merge? |
romain-intel
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to ensure non-pythonic conda dependencies are visible to the user code on AWS Batch