Add cli driver for all clients #159

amcp · 2018-04-13T04:12:04Z

Setup on EC2 Amazon Linux:

sudo yum update -y \
&& sudo yum upgrade -y \
&& sudo yum install -y java-1.8.0-openjdk-devel git emacs \
&& sudo yum remove -y java-1.7.0-openjdk \
&& git clone https://github.com/amcp/ndbench.git \
&& cd ndbench \
&& git checkout cli \
&& ./gradlew build

Test 1:

DISCOVERY_ENV=AWS ./gradlew run \
-Dndbench.config.cli.clientName=DynamoDBKeyValue \
-Dndbench.config.cli.bulkSize=1 \
-Dndbench.config.cli.timeoutMillis=180000 \
-Dndbench.config.dataSize=1000 \
-Dndbench.config.numKeys=1 \
-Dndbench.config.readEnabled=true \
-Dndbench.config.readRateLimit=20000 \
-Dndbench.config.writeEnabled=true \
-Dndbench.config.writeRateLimit=20000 \
-Dndbench.config.dynamodb.rcu=20000 \
-Dndbench.config.dynamodb.wcu=20000 \
-Dndbench.config.dynamodb.tablename=hires \
-Dndbench.config.dynamodb.consistentread=true \
-Dndbench.config.dynamodb.maxRetries=0 \
-Dndbench.config.dynamodb.requestTimeout=100 \
-Dndbench.config.dynamodb.maxConnections=400 \
-Dndbench.config.dynamodb.numReaders=200 \
-Dndbench.config.dynamodb.numWriters=200 \
-Dndbench.config.dynamodb.programmableTables=true

amcp · 2018-04-13T04:14:03Z

ndbench-cli/build.gradle

+dependencies {
+    compile project(':ndbench-core')
+    compile project(':ndbench-api')
+    compile (project(':ndbench-cass-plugins')) {


add the rest of the plugins in build.gradle when CLI support for them is implemented

amcp · 2018-04-13T04:14:37Z

ndbench-cli/src/main/java/com/netflix/ndbench/core/NdbenchEntrypoint.java

+ * @author amcp@amazon.com
+ */
+public class NdbenchEntrypoint {
+    public static class Args {


pull out to a separate class or figure out how to use Archaius interface for CLI

amcp · 2018-04-13T04:14:46Z

ndbench-cli/src/main/java/com/netflix/ndbench/core/NdbenchEntrypoint.java

+ * - add command line arguments for all generic and client-specific parameters
+ * -
+ *
+ * @author amcp@amazon.com


name not email

amcp · 2018-04-13T04:14:57Z

ndbench-cli/src/main/java/com/netflix/ndbench/core/NdbenchEntrypoint.java

@@ -0,0 +1,346 @@
+/*
+ *  Copyright 2018 Amazon Web Services, Inc.


amcp · 2018-04-13T04:16:57Z

ndbench-cli/src/main/java/com/netflix/ndbench/core/NdbenchEntrypoint.java

+        });
+
+        try {
+            driver.init(dynamodb); //TODO make database client configurable


add an argument for the driver

not implementing other drivers now, so put this feedback off.

amcp · 2018-04-13T04:18:12Z

ndbench-core/src/main/java/com/netflix/ndbench/core/generators/RandomStringKeyGenerator.java

@@ -31,7 +31,7 @@ public RandomStringKeyGenerator(boolean preLoadKeys, int numKeys) {

    @Override
    public String getNextKey() {
-        int randomKeyIndex = kRandom.nextInt(getNumKeys());
+        int randomKeyIndex = kRandom.nextInt(numKeys);


fix in another pr

#163 fixes #160

amcp · 2018-04-13T04:18:46Z

ndbench-dynamodb-plugins/build.gradle

@@ -4,7 +4,6 @@ repositories {
   }
 }

-


remove all the noise changes in this file

amcp · 2018-04-13T04:19:07Z

...nch-dynamodb-plugins/src/main/java/com/netflix/ndbench/plugin/dynamodb/DynamoDBKeyValue.java

@@ -252,8 +252,8 @@ public String writeSingle(String key) throws Exception {

    private List<WriteRequest> generateWriteRequests(List<String> keys) {
        return keys.stream()
-                .map(key -> ImmutableMap.of(partitionKeyName, new AttributeValue(key),
-                        ATTRIBUTE_NAME, new AttributeValue(this.dataGenerator.getRandomValue())))
+                .map(key -> ImmutableMap.of("id", new AttributeValue(key),


use the partitionKeyName field

amcp · 2018-04-13T04:19:26Z

ndbench-es-plugins/src/test/java/com/netflix/ndbench/plugin/es/AutotuneTest.java

@@ -15,7 +16,7 @@
    private static final Logger Logger = LoggerFactory.getLogger(AutotuneTest.class);


-    @Test
+    @Ignore


investigate

amcp · 2018-04-13T04:19:38Z

settings.gradle

@@ -1,3 +1,13 @@
 rootProject.name='ndbench'
-include 'ndbench-web','ndbench-api','ndbench-core','ndbench-cass-plugins','ndbench-sample-plugins','ndbench-dyno-plugins','ndbench-es-plugins','ndbench-geode-plugins','ndbench-janusgraph-plugins', 'ndbench-evcache-plugins', 'ndbench-dynamodb-plugins'
-
+include 'ndbench-web'


make this change in a different PR

fixed #161 in #164

amcp · 2018-04-14T17:00:00Z

evcache causes exceptions related to Eureka on startup. Any ideas?

amcp · 2018-04-14T17:45:56Z

Also, seems like the properties are not getting initialized, despite my customizations:

DISCOVERY_ENV=AWS ./gradlew run \
-Dndbench.config.cli.clientName=DynamoDBKeyValue \
-Dndbench.config.cli.bulkSize=25 \
-Dndbench.config.cli.timeoutMillis=360000 \
-Dndbench.config.dynamodb.maxConnections=112 \
-Dndbench.config.dynamodb.numWriters=35 \
-Dndbench.config.dynamodb.numReaders=77 \
-Dndbench.config.dataSize=1000 \
-Dndbench.config.numKeys=10000000 \
-Dndbench.config.readEnabled=true \
-Dndbench.config.readRateLimit=3000 \
-Dndbench.config.writeEnabled=true \
-Dndbench.config.writeRateLimit=3000

Result:

17:41:49,395  INFO NdbenchEntrypoint:43 - Starting driver in CLI with loadPattern=random, windowSize=-1, windowDurationInSec=-1, bulkSize=1, timeout(ms)=360000, clientName=InMemoryTest

amcp · 2018-04-15T04:26:29Z

@ipapapa I fixed the system property issue by modifying build.gradle. The following command now works:

DISCOVERY_ENV=AWS ./gradlew run \
-Dndbench.config.cli.clientName=DynamoDBKeyValue \
-Dndbench.config.cli.bulkSize=25 \
-Dndbench.config.cli.timeoutMillis=360000 \
-Dndbench.config.dataSize=1000 \
-Dndbench.config.numKeys=100000000 \
-Dndbench.config.readEnabled=true \
-Dndbench.config.readRateLimit=3000 \
-Dndbench.config.writeEnabled=true \
-Dndbench.config.writeRateLimit=3000 \
-Dndbench.config.dynamodb.consistentread=true \
-Dndbench.config.dynamodb.maxRetries=0 \
-Dndbench.config.dynamodb.requestTimeout=100 \
-Dndbench.config.dynamodb.maxConnections=62 \
-Dndbench.config.dynamodb.numWriters=36 \
-Dndbench.config.dynamodb.numReaders=26

ipapapa · 2018-04-15T13:45:29Z

In regards to Eureka, I am aware of the issue. It is also reported in #134 (cc @smadappa). I got sidetracked last week, but I am planning to work unless @smadappa beats me to it :)

ipapapa · 2018-04-15T13:48:05Z

LGTM... @vinaykumarchella ?

amcp · 2018-04-18T13:59:26Z

ndbench-core/src/main/java/com/netflix/ndbench/core/generators/StringKeyGenerator.java

-                keys.add("T" + i);
-            }
-            logger.info("Preloaded " + numKeys + " keys");
+            keys.addAll(IntStream.of(getNumKeys()).boxed().map(i -> "T" + i).collect(Collectors.toList()));


add a peek for the info statement

vinaykumarchella · 2018-04-18T20:09:04Z

Just back from short vacation, will go through it today and provide my comments on this

vinaykumarchella · 2018-04-18T21:13:42Z

ndbench-cli/src/main/java/com/netflix/ndbench/cli/NdbenchCli.java

+import org.slf4j.LoggerFactory;
+
+/**
+ * This class is a CLI entry point to facilitate quick testing of the Netflix Database Benchmark.


Netflix Database Benchmark --> Netflix Data Benchmark (NdBench)

vinaykumarchella · 2018-04-19T18:20:16Z

ndbench-cli/src/main/java/com/netflix/ndbench/cli/NdbenchCli.java

+                    Integer.valueOf(cliConfigs.getBulkSize())
+            );
+            long millisToWait = Integer.valueOf(cliConfigs.getCliTimeoutMillis());
+            logger.info("Waiting " + millisToWait + " ms for reads and writes to finish");


Does this deviate the goal of NdBench being run continuously without a preset time? Can we have default to run indefinitely and being in CLI, you can stop with program interruption inputs (e.g., CTRL+C etc.,). also if needed we can provide the functionality to set the time, lets say - default getCliTimeoutMillis would be 0 or -1, setting it to positive number goes through the timeout functionality.

With programmatic tables and large amounts of IOPS, it is easy to forget to delete the table after a Control-C and incur extra cost. The timeout is an extra safeguard to control the cost of experiments. I agree about overloading the meaning of non-positive numbers. Will fix.

vinaykumarchella · 2018-04-19T18:21:38Z

Overall looks good, provided minor feedback above

Partially addresses Netflix#118

vinaykumarchella

LGTM

amcp commented Apr 13, 2018

View reviewed changes

This was referenced Apr 13, 2018

Use numKeys field in RandomStringKeyGenerator::getNextKey #160

Closed

Alphabetize and newline-delimit modules names in settings.gradle #161

Closed

amcp force-pushed the cli branch 3 times, most recently from 536f570 to d0216bc Compare April 14, 2018 16:56

amcp changed the title ~~[WIP] Add cli driver~~ Add cli driver for all clients Apr 14, 2018

amcp force-pushed the cli branch 4 times, most recently from 2914272 to a14dc44 Compare April 14, 2018 17:41

amcp force-pushed the cli branch 5 times, most recently from 3d24ba5 to 049dd24 Compare April 15, 2018 04:14

ipapapa approved these changes Apr 15, 2018

View reviewed changes

ipapapa requested a review from vinaykumarchella April 15, 2018 13:48

ipapapa added the enhancement label Apr 15, 2018

amcp force-pushed the cli branch 6 times, most recently from 6bba88e to 981260a Compare April 16, 2018 01:22

amcp force-pushed the cli branch 6 times, most recently from 93ce80a to f6569b2 Compare April 18, 2018 04:18

amcp commented Apr 18, 2018

View reviewed changes

amcp force-pushed the cli branch from f6569b2 to 92310d5 Compare April 18, 2018 14:03

amcp force-pushed the cli branch from 92310d5 to 658f66b Compare April 18, 2018 21:11

amcp mentioned this pull request Apr 19, 2018

Update README.md #183

Open

3 tasks

vinaykumarchella reviewed Apr 19, 2018

View reviewed changes

amcp force-pushed the cli branch from 658f66b to 86ce47d Compare April 19, 2018 20:45

Add cli driver

f45c864

Partially addresses Netflix#118

amcp force-pushed the cli branch from 86ce47d to f45c864 Compare April 19, 2018 20:48

vinaykumarchella approved these changes Apr 19, 2018

View reviewed changes

vinaykumarchella merged commit 218c44c into Netflix:master Apr 19, 2018

amcp deleted the cli branch April 19, 2018 20:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cli driver for all clients #159

Add cli driver for all clients #159

amcp commented Apr 13, 2018 •

edited

Loading

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 16, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp Apr 16, 2018

amcp Apr 13, 2018

amcp Apr 13, 2018

amcp commented Apr 14, 2018

amcp commented Apr 14, 2018 •

edited

Loading

amcp commented Apr 15, 2018

ipapapa commented Apr 15, 2018

ipapapa commented Apr 15, 2018

amcp Apr 18, 2018

vinaykumarchella commented Apr 18, 2018

vinaykumarchella Apr 18, 2018

amcp Apr 19, 2018

vinaykumarchella Apr 19, 2018

amcp Apr 19, 2018

vinaykumarchella commented Apr 19, 2018

vinaykumarchella left a comment

		@@ -0,0 +1,346 @@
		/*
		* Copyright 2018 Amazon Web Services, Inc.

Add cli driver for all clients #159

Add cli driver for all clients #159

Conversation

amcp commented Apr 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amcp commented Apr 14, 2018

amcp commented Apr 14, 2018 • edited Loading

amcp commented Apr 15, 2018

ipapapa commented Apr 15, 2018

ipapapa commented Apr 15, 2018

Choose a reason for hiding this comment

vinaykumarchella commented Apr 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vinaykumarchella commented Apr 19, 2018

vinaykumarchella left a comment

Choose a reason for hiding this comment

amcp commented Apr 13, 2018 •

edited

Loading

amcp commented Apr 14, 2018 •

edited

Loading