Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot regression tests #244

Open
offirgolan opened this issue Aug 1, 2019 · 0 comments

Comments

@offirgolan
Copy link
Collaborator

commented Aug 1, 2019

Description

Because of the use of the InMemoryPersister (#233), we removed all the stored recordings generated by the tests which we used as a crutch to do semi-manual regression testing (e.g. check if certain attributes changed in the HAR file after making a change). Instead, we should write actual snapshot tests to catch these which will be significantly more useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.