Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document Jest & Jasmine support using setup-polly-jest #135

Merged
merged 1 commit into from Nov 13, 2018

Conversation

offirgolan
Copy link
Collaborator

@offirgolan offirgolan commented Nov 12, 2018

@gribnoysup I would love your review on this as well.

The Polly instance's recording name is derived from the current test name as well as its
parent module(s).

[README.md](https://raw.githubusercontent.com/gribnoysup/setup-polly-jest/master/README.md ':include :type=markdown')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will embed the entire readme into the page 😄

Copy link
Contributor

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@offirgolan that looks amazing, thank you so much for doing this! 🎉

@offirgolan
Copy link
Collaborator Author

No problem at all @gribnoysup. Thank you for putting this all together!

@offirgolan offirgolan merged commit 032af53 into master Nov 13, 2018
@offirgolan offirgolan deleted the setup-polly-jest branch November 13, 2018 01:37
@offirgolan
Copy link
Collaborator Author

Published 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants