New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor scripts and resolve circular dev dependencies #178

Merged
merged 2 commits into from Feb 1, 2019

Conversation

Projects
None yet
1 participant
@offirgolan
Copy link
Contributor

offirgolan commented Feb 1, 2019

No description provided.

@offirgolan offirgolan requested a review from jasonmit Feb 1, 2019

@@ -38,10 +38,10 @@
},
"scripts": {
"build": "lerna run build --ignore=@pollyjs/ember --parallel",
"build:prod": "lerna run build:prod --ignore=@pollyjs/ember --parallel",
"build:prod": "NODE_ENV=production yarn build && NODE_ENV=production MINIFY=true yarn build",

This comment has been minimized.

@offirgolan

offirgolan Feb 1, 2019

Author Contributor

Make sure we do a production build even if not minifying.

@offirgolan offirgolan changed the title chore: Refactor rollup and npm build scripts chore: Refactor scripts and resolve circular dev dependencies Feb 1, 2019

@offirgolan offirgolan merged commit b13c053 into master Feb 1, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@offirgolan offirgolan deleted the refactor-scripts branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment