Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter-fetch): Correctly handle key/value pairs headers #191

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@offirgolan
Copy link
Contributor

offirgolan commented Mar 5, 2019

Description

Correctly handle key/value pairs passed as headers to a fetch request.

Motivation and Context

Resolves #190.

A fetch request can receive headers in the following format: [['key1', 'value1'], ['key2', 'value2']]. To be able to support this format as well as any other formats, we create a new Headers instance with the original headers and serialize that. This allows us to have a normalized interface to interact with.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@offirgolan offirgolan requested a review from jasonmit Mar 5, 2019

@jasonmit jasonmit merged commit dc0323d into master Mar 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jasonmit jasonmit deleted the adapter-fetch-headers-fix branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.