Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter-puppeteer): Remove other resource type matching #197

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@jasonmit
Copy link
Member

jasonmit commented Apr 9, 2019

There was a change in Puppeteer 1.7 that forced us to start capturing "other" network requests.

This led to proxying requests for requests like favicons. This isn't optimal and thankfully is no longer needed as of Puppeteer >= 1.9.

fixes #149

@jasonmit jasonmit requested a review from offirgolan Apr 9, 2019

@jasonmit jasonmit closed this Apr 9, 2019

@jasonmit jasonmit reopened this Apr 9, 2019

@jasonmit jasonmit force-pushed the u/jasonmit/drop-other-from-puppeteer branch 2 times, most recently from 263a867 to 18f38ba Apr 9, 2019

@jasonmit jasonmit force-pushed the u/jasonmit/drop-other-from-puppeteer branch from 18f38ba to 42ceecb Apr 9, 2019

@jasonmit jasonmit force-pushed the u/jasonmit/drop-other-from-puppeteer branch from 42ceecb to 1d933fb Apr 9, 2019

@jasonmit jasonmit merged commit ea6bfcc into master Apr 9, 2019

1 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@jasonmit jasonmit deleted the u/jasonmit/drop-other-from-puppeteer branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.