Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Improved logging #217

Merged
merged 3 commits into from Jun 23, 2019

Conversation

Projects
None yet
2 participants
@offirgolan
Copy link
Collaborator

commented Jun 7, 2019

Description

Improve the current logging to make it more readable and add logging to error events.

Motivation and Context

The info that is currently logged isnt very readable and is hard to find the information you need when debugging.

Screen Shot 2019-06-06 at 11 18 22 PM

Screen Shot 2019-06-06 at 11 18 55 PM

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@offirgolan offirgolan requested a review from jasonmit Jun 7, 2019

@offirgolan offirgolan merged commit 3e876a8 into master Jun 23, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@offirgolan offirgolan deleted the improved-logging branch Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.