Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Mapbox GL fixes: handle `Request` objects as URLs (and array buffer responses discussion) #220
These are fixes I needed to get Polly working with Mapbox GL. So far the handling of an array buffer response is only for passthrough requests, not recording, is that a reasonable first step? There are no tests because I'd like some help thinking about how to test these.
Motivation and Context
I wonder if the handling of
I see in #183 that array buffer responses have already been considered.
Types of Changes
@tombh thanks for taking the time in opening up this PR!
This is definitely something that we should handle and should've been considered but I guess was missed. Can you split this into a separate PR so we can get this in faster as the ArrayBuffer work is going to be a bit more time consuming.
Due to the current nature of the client server API (
Im not exactly sure how you want to proceed with this but supporting binary data would need to work across all recording modes in order to be merged in.
Thanks for taking the time to land this @tombh. The CI failures are unrelated, we'll fix them separately.
Yeah, the current test/build system needs some work for sure. You can run a single test by using