Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Default to empty string if userAgent is empty #242

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@silverchen
Copy link
Contributor

commented Aug 1, 2019

Description

Bowser throws when userAgent is not a string. Default userAgent to empty string when it's empty fixes the issue.

Motivation and Context

This is to prevent non-browser app (React Native) from crashing.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.
Default to empty string if userAgent is empty
This is to prevent non-browser app (React Native) from crashing.

@offirgolan offirgolan merged commit c46d65c into Netflix:master Aug 1, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@offirgolan

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

Thank you for the PR @silverchen. Its been released under v2.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.