Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct Lerna link in contributing.md doc #245

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@shriyash
Copy link
Contributor

commented Aug 1, 2019

This is a quick document change to fix the Lerna link.

Description

Motivation and Context

Types of Changes

Document change.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@shriyash shriyash changed the title fix: correct Lerna link in contributing.md doc doc: correct Lerna link in contributing.md doc Aug 1, 2019

@shriyash shriyash changed the title doc: correct Lerna link in contributing.md doc fix: correct Lerna link in contributing.md doc Aug 1, 2019

@offirgolan

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

Thanks for the PR @shriyash!

@offirgolan offirgolan merged commit 24fd6f7 into Netflix:master Aug 1, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.