Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adapter-node-http): Upgrade nock to v11.x #273

merged 2 commits into from Nov 21, 2019


Copy link

offirgolan commented Nov 4, 2019


Motivation and Context

Resolves #263, #264

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)


  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.
const contentType = (headers['content-type'] || '').toString();
const isMultiPart = contentType.includes('multipart');

if (body) {

This comment has been minimized.

Copy link

jasonmit Nov 6, 2019


Seems some overlap between these changes and

This comment has been minimized.

Copy link

offirgolan Nov 19, 2019

Author Collaborator

Yeah there is some overlap. @swashcap can validate and we can add some more test cases in that PR.

@offirgolan offirgolan marked this pull request as ready for review Nov 19, 2019
@offirgolan offirgolan requested a review from jasonmit Nov 19, 2019
@offirgolan offirgolan merged commit 5d42cbd into master Nov 21, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@offirgolan offirgolan deleted the upgrade-nock-to-11.x branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.