Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Provide the request as an argument to matchRequestsBy methods #293

Merged
merged 3 commits into from Jan 13, 2020

Conversation

@offirgolan
Copy link
Collaborator

offirgolan commented Jan 13, 2020

Description

Provide the request as an argument to all custom matchRequestsBy functions to provide more context. Also allow for matchRequestsBy.url to be a custom function.

Motivation and Context

Resolves #274.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.
@offirgolan offirgolan requested a review from jasonmit Jan 13, 2020
@offirgolan offirgolan merged commit 4e3163f into master Jan 13, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@offirgolan offirgolan deleted the matchRequestsBy-request-context branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.