Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter): Clone the recording entry before mutating it #294

Merged
merged 2 commits into from Jan 13, 2020

Conversation

@offirgolan
Copy link
Collaborator

offirgolan commented Jan 13, 2020

Description

Clone the recording entry before the beforeReplay event so any changes will not actually persist to the stored recording.

Motivation and Context

Resolves #265.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.
Clone the recording entry so any changes will not actually persist to the stored recording.
packages/@pollyjs/adapter/src/index.js Outdated Show resolved Hide resolved
@offirgolan offirgolan merged commit d7e1303 into master Jan 13, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@offirgolan offirgolan deleted the clone-recording-entry-on-replay branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.