This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
Load whole config for SQS #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the SQS watcher and ignored any queue without a policy. This meant a subset of queues were invisible to security monkey. Now, load all configuration for all SQS items, and make the policy a child object, rather than the top level. Delete the item counts from SQS items, as they change constantly, and we don't care.
scriptsrc
reviewed
Aug 18, 2017
security_monkey/watchers/sqs.py
Outdated
| # Delete ephemeral values | ||
| del attrs['ApproximateNumberOfMessagesNotVisible'] | ||
| del attrs['ApproximateNumberOfMessages'] | ||
| del attrs['ApproximateNumberOfMessagesDelayed'] |
There was a problem hiding this comment.
Instead of deleting ephemeral things, we can just tell SM that they are ephemeral:
Example from S3: https://github.com/Netflix/security_monkey/blob/develop/security_monkey/watchers/s3.py#L15
Example from IAM User: https://github.com/Netflix/security_monkey/blob/develop/security_monkey/watchers/iam/iam_user.py#L14
Just put this in the watcher constructor:
self.ephemeral_paths = [
'ApproximateNumberOfMessagesNotVisible',
'ApproximateNumberOfMessages',
'ApproximateNumberOfMessagesDelayed']
|
Derp, sorry I didn't get back to this sooner. Thanks for making that fix. |
Boto returns weird types that don't interact well with `deepcopy`. Casting to a `dict` fixes it.
|
Cool! Just updated my instance, and it is slurping up the rest of the SQS items ❤️ (and spotting issues 😅). |
|
It looks like the ephemeral path filtering doesn't work? I am seeing the configs get captured for all SQS items every hour, as the message counts are changing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for feedback to start with, haven't tested this yet. Want to make sure that this kind of item config change is kosher.
Commit message follows:
Previously, the SQS watcher and ignored any queue without a policy. This
meant a subset of queues were invisible to security monkey.
Now, load all configuration for all SQS items, and make the policy a
child object, rather than the top level.
Delete the item counts from SQS items, as they change constantly, and we
don't care.