Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
use compile scope for deps in public api (#316)
Gradle by default will publish these to the POM
using runtime scope. This changes dependencies
that are exposed via public APIs to get placed
in the compile scope of the POM.

Verified using:

```
$ ./gradlew spectator-reg-metrics3:generatePomFileForNebulaPublication
$ diff before spectator-reg-metrics3/build/publications/nebula/pom-default.xml
```

Diff:

```diff
18c18
<       <scope>runtime</scope>
---
>       <scope>compile</scope>
24c24
<       <scope>runtime</scope>
---
>       <scope>compile</scope>
50c50
<     <nebula_Build_Date>2016-09-01_05:33:46</nebula_Build_Date>
---
>     <nebula_Build_Date>2016-09-01_05:39:17</nebula_Build_Date>
```
  • Loading branch information
brharrington committed Sep 1, 2016
1 parent 56f0b4c commit 7176aa1
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 12 deletions.
1 change: 1 addition & 0 deletions build.gradle
Expand Up @@ -32,6 +32,7 @@ allprojects {

subprojects {
apply plugin: 'nebula.netflixoss'
apply plugin: 'nebula.compile-api'
apply plugin: 'java'
apply plugin: 'build-dashboard'
apply plugin: 'jacoco'
Expand Down
4 changes: 2 additions & 2 deletions spectator-ext-aws/build.gradle
@@ -1,5 +1,5 @@
dependencies {
compile project(":spectator-api")
compile "com.amazonaws:aws-java-sdk-core"
compileApi project(":spectator-api")
compileApi "com.amazonaws:aws-java-sdk-core"
testCompile "com.amazonaws:aws-java-sdk-cloudwatch"
}
2 changes: 1 addition & 1 deletion spectator-ext-gc/build.gradle
@@ -1,3 +1,3 @@
dependencies {
compile project(':spectator-api')
compileApi project(':spectator-api')
}
2 changes: 1 addition & 1 deletion spectator-ext-jvm/build.gradle
@@ -1,3 +1,3 @@
dependencies {
compile project(':spectator-api')
compileApi project(':spectator-api')
}
6 changes: 3 additions & 3 deletions spectator-ext-log4j2/build.gradle
@@ -1,5 +1,5 @@
dependencies {
compile project(':spectator-api')
compile "org.apache.logging.log4j:log4j-api"
compile "org.apache.logging.log4j:log4j-core"
compileApi project(':spectator-api')
compileApi "org.apache.logging.log4j:log4j-api"
compileApi "org.apache.logging.log4j:log4j-core"
}
2 changes: 1 addition & 1 deletion spectator-ext-sandbox/build.gradle
@@ -1,3 +1,3 @@
dependencies {
compile project(':spectator-api')
compileApi project(':spectator-api')
}
4 changes: 2 additions & 2 deletions spectator-reg-metrics3/build.gradle
@@ -1,5 +1,5 @@
dependencies {
compile project(':spectator-api')
compile 'io.dropwizard.metrics:metrics-core:3.1.2'
compileApi project(':spectator-api')
compileApi 'io.dropwizard.metrics:metrics-core:3.1.2'
jmh project(':spectator-api')
}
4 changes: 2 additions & 2 deletions spectator-reg-servo/build.gradle
@@ -1,5 +1,5 @@
dependencies {
compile project(':spectator-api')
compile 'com.netflix.servo:servo-core'
compileApi project(':spectator-api')
compileApi 'com.netflix.servo:servo-core'
jmh project(':spectator-api')
}

0 comments on commit 7176aa1

Please sign in to comment.