firefox rendering bug: individual widget charts clipped at 150px tall

[fche]

On firefox 40.0.3 (Fedora21), every widget appears clipped to the top 150 pixels, dropping the bottom axis & labels. Chrome & epiphany on same platform seem fine. Browsing with firebug unfortunately not enough for this newb to diagnose the cause. It appears to be a regression in 1.0.2 since 1.0.1.

[fche]

This problem persists to git master vector, not just the v1.0.2 release.

[hc000]

I think there is a difference in the way firefox implements svg vs chrome.
To fix this problem in firefox, just need to set the size with px instead of %

[spiermar]

Interesting. The 100% is coming from the default nvd3 css. There's an inline element style setting the px value, but Firefox is ignoring it. That's why FF is trying to use the % value.
I'm using inline because this is calculated based on the widget config. Have to figure out why FF is ignoring it.

[spiermar]

Setting the style manually works, but for some reason, d3 is not setting it on FF.

This should take care of setting the inline style:

vector/src/app/charts/line-timeseries.directive.js

Line 70 in ecfcd08

.style({'height': height})

[spiermar]

Fixed it, just waiting to get my access back. Was away for so long they forgot about me. :-)

[spiermar]

2a6f45c

Can you check @fche ?

[fche]

That does it, thanks!

[fche]

Aw man, still seing the phenomenon on -some- of the charts.
Yeah, the "CPU Utilization", "Memory Utilization" and "Page Faults" views.- the bar charts?

[hc000]

@fche I just made a commit, can you try now?

[spiermar]

Oops, missed the stacked charts. Tks @hc000 !

[spiermar]

Assuming this is working now. Closing the issue, but let me know if I'm wrong. ;-)