/vector

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Correct a metric name in the Network Retransmits widget #133

Merged
merged 1 commit into from Aug 11, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@natoscott @spiermar @fche
@natoscott
Contributor

natoscott commented Aug 11, 2016

Stumbled into this one thanks to some notes from Henry;
there was a rogue "c" in "network.tcp.synretrans" use.
@natoscott
Correct a metric name in the Network Retransmits widget 
Stumbled into this one thanks to some notes from Henry;
there was a rogue "c" in "network.tcp.synretrans" use.
458a926
@spiermar
Contributor

spiermar commented Aug 11, 2016

Tks @natoscott !

@spiermar spiermar merged commit a417ef2 into Netflix:master Aug 11, 2016

natoscott added a commit to performancecopilot/pcp that referenced this pull request Aug 11, 2016

@natoscott
pmlogconf: correction to synretrans metric in vector 
Chalk another one up for PCP QA: the set of metrics that
Henry extracted from Vector showed up a metric name typo
and the pmlogconf regression tests noticed.  Vector fix:
Netflix/vector#133
b3c1872
@spiermar
Contributor

spiermar commented Sep 9, 2016

@natoscott was this changed recently? Asking because I'm not getting the network.tcp.synretrans metric in our system, but we're running an older version of PCP.
@fche
Contributor

fche commented Sep 9, 2016

The above commit was made on Aug. 11, after pcp 3.11.4 was cut.
@spiermar
Contributor

spiermar commented Sep 9, 2016

Ok, that explains it. :-) Tks @fche
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment