New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bower #194

Merged
merged 7 commits into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@jasonk000
Contributor

jasonk000 commented Jun 26, 2018

Removes need for bower in the build process.

Simplifies dependency installation.

$ npm install
$ npm run build
$ npm run test
$ npm run serve

(Will require a documentation update for getvector.io)

@jasonk000 jasonk000 requested a review from spiermar Jun 26, 2018

jasonk000 and others added some commits Jun 26, 2018

Update index.html
Nitpicking html comments.
@spiermar

LGTM. Just need to add editorconfig.

/**
* Most straightforward way to load dependencies in order with gulp
* Need to move to webpack

This comment has been minimized.

@spiermar

spiermar Jun 28, 2018

Contributor

Assuming temporary until we migrate to webpack.

@spiermar

spiermar Jun 28, 2018

Contributor

Assuming temporary until we migrate to webpack.

This comment has been minimized.

@jasonk000

jasonk000 Jun 28, 2018

Contributor

correct, working on that at the moment

@jasonk000

jasonk000 Jun 28, 2018

Contributor

correct, working on that at the moment

"clean": "gulp clean",
"build": "gulp build",
"test": "gulp test",
"serve": "gulp serve"
},
"devDependencies": {

This comment has been minimized.

@spiermar

spiermar Jun 28, 2018

Contributor

Missing editorconfig.

@spiermar

spiermar Jun 28, 2018

Contributor

Missing editorconfig.

This comment has been minimized.

@jasonk000

jasonk000 Jun 28, 2018

Contributor

TIL editorconfig

@jasonk000

jasonk000 Jun 28, 2018

Contributor

TIL editorconfig

This comment has been minimized.

@jasonk000

jasonk000 Jun 28, 2018

Contributor

@spiermar is editorconfig actually needed as a dep of this project? I don't see why editorconfig would need to be part of the project dev deps.

@jasonk000

jasonk000 Jun 28, 2018

Contributor

@spiermar is editorconfig actually needed as a dep of this project? I don't see why editorconfig would need to be part of the project dev deps.

This comment has been minimized.

@jasonk000

jasonk000 Jun 28, 2018

Contributor

as discussed, will leave this out and do linter cleanups as a separate pr

@jasonk000

jasonk000 Jun 28, 2018

Contributor

as discussed, will leave this out and do linter cleanups as a separate pr

@jasonk000 jasonk000 merged commit d937359 into master Jun 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jasonk000 jasonk000 deleted the remove-bower branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment