Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firewall web interface: wrong selected time condition #5200

Closed
gsanchietti opened this issue Jan 17, 2017 · 3 comments
Closed

Firewall web interface: wrong selected time condition #5200

gsanchietti opened this issue Jan 17, 2017 · 3 comments
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
NethServer 7
Milestone
v7

Comments

@gsanchietti
Copy link
Member

The user can't correctly choose a time condition during the creation of a rule.

Steps to reproduce

  • Create a time condition named "time1"
  • Create a new firewall rule and click on the time condition field
  • Select the time condition named "time1"

Expected behavior
The chosen time condition should be displayed under the time condition field.

Actual behavior
The chosen time condition is "Always"

Workaround
Save the ruled, then edit again and change the time condition.

Reference: http://community.nethserver.org/t/creating-fw-rules-choosing-time-condition/5348

Thanks to @maddin for reporting.
@gsanchietti gsanchietti added the bug A defect of the software label Jan 17, 2017
@gsanchietti gsanchietti added this to the v7 milestone Jan 17, 2017
@DavidePrincipi DavidePrincipi self-assigned this Jan 17, 2017
@DavidePrincipi DavidePrincipi mentioned this issue Jan 19, 2017
Merged
DavidePrincipi added a commit to NethServer/nethserver-firewall-base that referenced this issue Jan 19, 2017
@DavidePrincipi
Merge pull request #41 from DavidePrincipi/master
fbca68c 
Fix TimeRaw handling in rule creation

NethServer/dev#5200
@DavidePrincipi DavidePrincipi removed their assignment Jan 19, 2017
@DavidePrincipi DavidePrincipi added the testing Packages are available from testing repositories label Jan 19, 2017
@DavidePrincipi
Copy link
Member

In nethserver-testing:
nethserver-firewall-base-ui-3.1.5-1.2.gfbca68c.ns7.noarch.rpm
nethserver-firewall-base-3.1.5-1.2.gfbca68c.ns7.noarch.rpm

@gsanchietti gsanchietti added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Jan 19, 2017
@gsanchietti
Copy link
Member Author

Tested edit and new records: issue fixed.

@gsanchietti
Copy link
Member Author

Released:

  • nethserver-firewall-base-ui-3.1.6-1.ns7.noarch.rpm
  • nethserver-firewall-base-3.1.6-1.ns7.noarch.rpm

@gsanchietti gsanchietti removed this from Final in NethServer 7 Jan 30, 2017
@DavidePrincipi DavidePrincipi added this to Done in NethServer 7 Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
No open projects
NethServer 7
🗑 Done
Milestone
v7
Development

No branches or pull requests
2 participants
@gsanchietti @DavidePrincipi