New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEXTINPUT_PASSWORD fields rendered as plain text #5553

Closed
dnutan opened this Issue Jul 24, 2018 · 5 comments

Comments

4 participants
@dnutan

dnutan commented Jul 24, 2018

Password fields in nethserver-backup-data module are not masked.
In the backend they are set as of password field type but are rendered as normal text fields.
@DavidePrincipi found it is due to misplaced parentheses.

Components (NethServer 7.5)
>= nethserver-backup-data-1.3.4-1

See also
https://community.nethserver.org/t/textinput-password-fields-rendered-as-plain-text/10365?u=dnutan

Fix
PR

@dnutan dnutan added the bug label Jul 24, 2018

DavidePrincipi added a commit to NethServer/nethgui that referenced this issue Aug 6, 2018

DavidePrincipi added a commit to NethServer/nethserver-httpd-admin that referenced this issue Aug 6, 2018

DavidePrincipi added a commit to NethServer/nethserver-backup-data that referenced this issue Aug 6, 2018

@DavidePrincipi DavidePrincipi added this to ✋ Needs review in NethServer 7 via automation Aug 6, 2018

@DavidePrincipi DavidePrincipi moved this from ✋ Needs review to ⚙ Developing in NethServer 7 Aug 6, 2018

@nethbot

This comment has been minimized.

Show comment
Hide comment
@nethbot
Member

nethbot commented Aug 6, 2018

@nethbot

This comment has been minimized.

Show comment
Hide comment
@nethbot
Member

nethbot commented Aug 6, 2018

@stephdl stephdl self-assigned this Aug 7, 2018

@stephdl

This comment has been minimized.

Show comment
Hide comment
@stephdl

stephdl commented Aug 7, 2018

see QA at #5554 (comment)

@nethbot

This comment has been minimized.

Show comment
Hide comment
@nethbot
Member

nethbot commented Aug 8, 2018

DavidePrincipi added a commit to NethServer/nethserver-backup-data that referenced this issue Aug 8, 2018

@nethbot

This comment has been minimized.

Show comment
Hide comment
@nethbot
Member

nethbot commented Aug 8, 2018

NethServer 7 automation moved this from ⚙ Developing to 🗑 Done Aug 8, 2018

@NethServer NethServer deleted a comment from nethbot Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment