Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail2ban: asterisk jail is always sending email #5829

Closed
stephdl opened this issue Sep 9, 2019 · 6 comments

Comments

@stephdl
Copy link

commented Sep 9, 2019

Steps to reproduce

  • Install asterisk and fail2ban
  • disable to send email when a ban occurs
  • wait after attackers, even when email is disabled, fail2ban is sending email

Expected behavior

I expect that fail2ban honor the property $fail2ban{Mail}

Actual behavior

Asterisk jail gets a default configuration in jail.conf to always sends email, we need to overwrite it in jail.local

Components
nethserver-fail2ban-1.1.9-1
See also

https://community.nethserver.org/t/fail2ban-asterisk-jail-doesnt-follow-the-email-notification-setting/13344


thank pagaille

@stephdl stephdl self-assigned this Sep 9, 2019

@stephdl stephdl added the bug label Sep 9, 2019

@stephdl stephdl added this to ✋ Needs review in NethServer 7 via automation Sep 9, 2019

@stephdl stephdl moved this from ✋ Needs review to ⚙ Developing in NethServer 7 Sep 9, 2019

stephdl added a commit to NethServer/nethserver-fail2ban that referenced this issue Sep 10, 2019
Merge pull request #67 from stephdl/asteriskMail
Overwrite the default action for the asterisk jail NethServer/dev#5829
@nethbot

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

in 7.6.1810/testing:

@stephdl

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

QA

  • Install nethserver-fail2ban from testing with asterisk

  • check if no errors inside /var/log/messages after the installation

  • disable email for all jail

config setprop fail2ban Mail disabled
signal-event nethserver-fail2ban-save
  • check if the asterisk* jails still get the action with mail (it must not)
    fail2ban-client -d | grep mail | less

  • wait after attackers and check if the ban occurs without emails warning

@stephdl stephdl removed their assignment Sep 10, 2019

@stephdl stephdl added the testing label Sep 10, 2019

@pagaille

This comment has been minimized.

Copy link

commented Sep 16, 2019

Tested both cases : mail enabled and mail disabled. Working as expected. Thanks !

@gsanchietti

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

Thank you for the testing, marking verified.

@gsanchietti gsanchietti added verified and removed testing labels Sep 16, 2019

@nethbot

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

in 7.6.1810/updates:

@stephdl

This comment has been minimized.

Copy link
Author

commented Sep 16, 2019

released, set closed

@stephdl stephdl closed this Sep 16, 2019

NethServer 7 automation moved this from ⚙ Developing to 🗑 Done Sep 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.