Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junk folder for public mailboxes #5843

Closed
DavidePrincipi opened this issue Sep 20, 2019 · 6 comments

Comments

@DavidePrincipi
Copy link
Member

@DavidePrincipi DavidePrincipi commented Sep 20, 2019

The Junk mail folder related to the public mailboxes is deleted every night by /etc/cron.daily/nethserver-mail-spam-expunge, loosing its content and all the possible ACL added on that folder.

It would be more consistent to treat its contents like any other user's Junk folder, obeying to the spam retention policy.

Proposed solution

the public mailboxes Junk folder:

  • should be present by default
  • should be accessible only from admins
  • shouldn't be deleted from the UI (NethGUI nor Cockpit)

See also

@DavidePrincipi DavidePrincipi self-assigned this Sep 20, 2019
@DavidePrincipi DavidePrincipi added this to ✋ Needs review in NethServer 7 via automation Sep 20, 2019
@DavidePrincipi DavidePrincipi added this to the 7.7.1908 milestone Sep 20, 2019
@DavidePrincipi DavidePrincipi moved this from ✋ Needs review to ⚙ Developing in NethServer 7 Sep 20, 2019
@DavidePrincipi DavidePrincipi added this to To do in Cockpit via automation Sep 26, 2019
@DavidePrincipi DavidePrincipi moved this from To do to In progress in Cockpit Sep 26, 2019
DavidePrincipi added a commit to NethServer/nethserver-mail that referenced this issue Sep 26, 2019
Display Junk public mailbox in read-only state

NethServer/dev#5843
@DavidePrincipi DavidePrincipi removed their assignment Sep 26, 2019
@nethbot

This comment has been minimized.

Copy link
Member

@nethbot nethbot commented Sep 26, 2019

in 7.7.1908/testing:

@DavidePrincipi

This comment has been minimized.

Copy link
Member Author

@DavidePrincipi DavidePrincipi commented Sep 26, 2019

Test cases

  1. on new installation, the Junk folder must be visible in Nethgui and Cockpit app.
  2. on RPM update, the Junk folder (or whatever value set in dovecot/SpamFolder prop) gets fixed in the following way:
    1. if the folder does not already exist it is created
    2. if the ACLs are completely missing a default entry for root is added
  3. Changing ACLs is possible with the Junk item in Cockpit and Nethgui. Other operations are disabled/forbidden.
@lucagasparini

This comment has been minimized.

Copy link

@lucagasparini lucagasparini commented Sep 27, 2019

During the test case 3 I detected a problem: it is not possible to add ACL.
The invoked API generates this error:

]# echo '{"action":"update-public","acls":[{"right":"custom","global":"","rawrights":"admin create delete expunge insert lookup post read write writleted write-seen","name":"root","displayname":"root","type":"user","id":"user=root"},{"name":"test@adnethesis.it","displayname":"sonicle","type":"user","right":"full"}],"name":"Junk"}' | /usr/bin/sudo /usr/libexec/nethserver/api/nethserver-mail/mailbox/validate | jq

  "type": "NotValid",
  "message": "validation_failed",
  "attributes": [
    {
      "parameter": "rights",
      "value": null,
      "error": "invalid_rights"
    }
  ]
}
@DavidePrincipi DavidePrincipi self-assigned this Sep 27, 2019
@DavidePrincipi DavidePrincipi removed the testing label Sep 27, 2019
gsanchietti added a commit to NethServer/nethserver-mail that referenced this issue Sep 30, 2019
Fix custom ACLs entries for public mailboxes

NethServer/dev#5843
@nethbot

This comment has been minimized.

Copy link
Member

@nethbot nethbot commented Sep 30, 2019

in 7.7.1908/testing:

@gsanchietti

This comment has been minimized.

Copy link
Member

@gsanchietti gsanchietti commented Sep 30, 2019

No more validation errors, also custom ACL are now read-only inside Cockpit UI.

Verified.

@gsanchietti gsanchietti added verified and removed testing labels Sep 30, 2019
@nethbot

This comment has been minimized.

Copy link
Member

@nethbot nethbot commented Oct 1, 2019

in 7.7.1908/updates:

@gsanchietti gsanchietti closed this Oct 1, 2019
NethServer 7 automation moved this from ⚙ Developing to 🗑 Done Oct 1, 2019
Cockpit automation moved this from In progress to Done Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
NethServer 7
🗑 Done
4 participants
You can’t perform that action at this time.