Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail2ban: Jails postfix-sasl and postfix-rbl have been removed #6053

Closed
stephdl opened this issue Feb 6, 2020 · 3 comments
Closed

Fail2ban: Jails postfix-sasl and postfix-rbl have been removed #6053

stephdl opened this issue Feb 6, 2020 · 3 comments
Labels

Comments

@stephdl
Copy link

@stephdl stephdl commented Feb 6, 2020

Steps to reproduce

The jail postfix-sasl and postfix-rbl have been removed you can find the changelog at https://github.com/fail2ban/fail2ban/blob/0.10/ChangeLog

filter.d/postfix-rbl.conf: removed (replaced with postfix[mode=rbl])
filter.d/postfix-sasl.conf: removed (replaced with postfix[mode=auth])

the relevant filters have been removed

[root@NS7 ~]# ll /etc/fail2ban/filter.d/postfix*
-rw-r--r-- 1 root root 3100 Jan 10 13:34 /etc/fail2ban/filter.d/postfix.conf
-rw-r--r-- 1 root root  192 Feb  2 12:58 /etc/fail2ban/filter.d/postfix-ddos.conf
-rw-r--r-- 1 root root  481 Feb  2 12:58 /etc/fail2ban/filter.d/postfix-sasl-abuse.conf

Expected behavior

I expect the option are no more available in the UI (for Postfix-rbl) and in the jail.local for (Postfix-rbl and postfix-sasl)

Actual behavior

The two jails let us think that we can enable it, it is a bug

Components

nethserver-fail2ban

See also

https://community.nethserver.org/t/fail2ban-postfix-sasl-and-postfix-rbl-not-enabling-or-running/14607/


thank Reggie Ho

@stephdl stephdl added the bug label Feb 6, 2020
@stephdl stephdl self-assigned this Feb 6, 2020
@DavidePrincipi DavidePrincipi added this to ⚙ Developing in NethServer 7 Feb 7, 2020
stephdl added a commit to NethServer/nethserver-fail2ban that referenced this issue Feb 10, 2020
Remove obsolete jails postfix-{sasl,rbl} NethServer/dev#6053
@nethbot

This comment has been minimized.

Copy link
Member

@nethbot nethbot commented Feb 10, 2020

in 7.7.1908/testing:

@stephdl

This comment has been minimized.

Copy link
Author

@stephdl stephdl commented Feb 10, 2020

QA

We have removed the postfix-sasl and the postfix-rbl jails of fail2ban, they have been merged inside postfix

to verify:

  • you have to check inside /etc/fail2ban/jail.local if the two jails are no more listed
  • you have to check that fail2ban-client status does not output that two jails
  • you have to check that cockpit does not list the jail postfix-rbl in the UI and you have no errors to save the settings
  • you have to check that NethGui does not list the jail postfix-rbl in the UI and you have no errors to save the settings
@stephdl stephdl removed their assignment Feb 10, 2020
@stephdl stephdl added the testing label Feb 10, 2020
@gsanchietti gsanchietti added verified and removed testing labels Feb 10, 2020
@nethbot

This comment has been minimized.

Copy link
Member

@nethbot nethbot commented Feb 11, 2020

in 7.7.1908/updates:

NethServer 7 automation moved this from ⚙ Developing to 🗑 Done Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
NethServer 7
🗑 Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.