Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firewall: application name change breaks delegation #6388

Closed
gsanchietti opened this issue Jan 8, 2021 · 6 comments
Closed

Firewall: application name change breaks delegation #6388

gsanchietti opened this issue Jan 8, 2021 · 6 comments
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@gsanchietti
Copy link
Member

gsanchietti commented Jan 8, 2021 •
edited

After implementation of #6382, some new regressions have been emerged:

  • delegation doesn't work anymore
  • existing shortcuts to "Firewall" application points to a non-existing app
  • link to "Firewall" app inside the launcher points to a non-existing app

Fixing such regression is hard and can bring other unexpected bug.

Since the UI already clearly states what packages will be removed, we are going to revert the patch without fixing the real bug.

--

See also https://community.nethserver.org/t/firewall-not-found/17327
@gsanchietti gsanchietti added the bug A defect of the software label Jan 8, 2021
This was referenced Jan 8, 2021
Merged
Merged
gsanchietti added a commit to NethServer/nethserver-cockpit that referenced this issue Jan 8, 2021
@gsanchietti
Revert "UI: change nethserver-firewall-base id (#310)" (#312)
62d1c4c 
This reverts commit de842b1.

Reverts #310

NethServer/dev#6388
gsanchietti added a commit to NethServer/nethserver-firewall-base that referenced this issue Jan 8, 2021
@gsanchietti
Revert "Fix removal" (#170)
b1cc2e4 
Reverts #168

NethServer/dev#6388
@gsanchietti
Copy link
Member Author

Test case

  • Update an existing machine
  • Verify the delegation and the shortcuts are still working

@nethbot
Copy link
Member

nethbot commented Jan 8, 2021

in 7.9.2009/testing:

@nethbot
Copy link
Member

nethbot commented Jan 8, 2021

in 7.9.2009/testing:

@gsanchietti gsanchietti added the testing Packages are available from testing repositories label Jan 8, 2021
@edospadoni edospadoni self-assigned this Jan 8, 2021
@edospadoni
Copy link
Member

Test case: VERIFIED

  • shortcuts: OK
  • launcher: OK
  • delegation: OK

@edospadoni edospadoni added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Jan 8, 2021
@edospadoni edospadoni removed their assignment Jan 8, 2021
@nethbot
Copy link
Member

nethbot commented Jan 8, 2021

in 7.9.2009/updates:

@nethbot
Copy link
Member

nethbot commented Jan 8, 2021

in 7.9.2009/updates:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gsanchietti @edospadoni @nethbot