Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail2ban-unban is a wrapper to unban #81

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@stephdl
Copy link
Collaborator

stephdl commented Dec 1, 2019

@stephdl stephdl requested a review from gsanchietti Dec 1, 2019
@nethbot

This comment has been minimized.

Copy link
Member

nethbot commented Dec 1, 2019

in 7.7.1908/autobuild:

@stephdl stephdl force-pushed the stephdl:unbanWrapper branch from f328e22 to 77f12ae Dec 1, 2019
@nethbot

This comment has been minimized.

Copy link
Member

nethbot commented Dec 1, 2019

in 7.7.1908/autobuild:

Copy link
Member

gsanchietti left a comment

IMO this new command doesn't make any sense: it's just a wrapper to another command without any logic.

But if you strongly believe that is useful, please merge it after fail2ban 0.10 has been released.

@stephdl

This comment has been minimized.

Copy link
Collaborator Author

stephdl commented Dec 2, 2019

@gsanchietti we have an important decision to take (I'm kidding), either we merge my PR or we modify the documentation

I think that our users know this cmd, looks dnutan it was one of his first comment

@gsanchietti

This comment has been minimized.

Copy link
Member

gsanchietti commented Dec 2, 2019

It could be considered a regressions if users are expecting to see the command.

You're calle, feel free to merge it! ;)

@stephdl stephdl merged commit 37197ac into NethServer:master Dec 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stephdl stephdl mentioned this pull request Dec 2, 2019
@stephdl stephdl deleted the stephdl:unbanWrapper branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.