New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardening tls following tls-policy-save #6

Merged
merged 6 commits into from Mar 28, 2018

Conversation

Projects
None yet
3 participants
@stephdl
Copy link
Contributor

stephdl commented Mar 20, 2018

@nethbot

This comment has been minimized.

Copy link
Member

nethbot commented Mar 20, 2018

@DavidePrincipi
Copy link
Member

DavidePrincipi left a comment

Let's see it in action ;)

my $tlsPolicy = $tls{'policy'} || 'legacy';

if ($tlsPolicy eq 'legacy') {
return '';

This comment has been minimized.

@DavidePrincipi

DavidePrincipi Mar 21, 2018

Member

return statement or using $OUT variable? Both are good in this case, but should be used consistently.

@nethbot

This comment has been minimized.

Copy link
Member

nethbot commented Mar 21, 2018

@nethbot

This comment has been minimized.

Copy link
Member

nethbot commented Mar 23, 2018

@DavidePrincipi
Copy link
Member

DavidePrincipi left a comment

Same as httpd-admin: comment line with policy value (?)

@nethbot

This comment has been minimized.

Copy link
Member

nethbot commented Mar 27, 2018

@stephdl stephdl merged commit b8425de into NethServer:master Mar 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stephdl stephdl deleted the stephdl:HardeningTLS branch Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment