fix(ui): add NsProgressStories & other fixes #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre8244
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Storybook stories for the NsProgress component, integrates it into the Import Users modal, fixes i18n parameter inconsistencies, adds new translation strings for external applications, disables Carbon telemetry, and removes an unnecessary devcontainer extension.
- Adds NsProgress component stories and integration into Import Users modal with step indicators
- Fixes Italian i18n parameter naming from
{modulo_id}to{module_id}for consistency - Adds new translation strings for the
apps_statussection used by external applications
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/ui/src/stories/NsProgress.stories.js | Adds Storybook stories for NsProgress component with default and custom step examples |
| core/ui/src/components/domains/ImportUsersModal.vue | Integrates NsProgress component to display import wizard steps with styling |
| core/ui/public/i18n/it/translation.json | Fixes parameter naming inconsistencies and adds apps_status translation strings |
| core/ui/public/i18n/en/translation.json | Adds apps_status translation strings and updates restart-module action label |
| core/ui/.env | Disables Carbon Design System telemetry |
| .devcontainer/devcontainer.json | Removes waderyan.gitblame extension from devcontainer configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nethserver/ns8-ui-lib(see fix: typo in NsPasswordInput prop & sbom workflow ns8-ui-lib#49)