-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poseidon hash builtin #437
Conversation
@cicr99 I used this implementation of hades permutation and poseidon hash (https://github.com/NethermindEth/juno/blob/main/core/crypto/poseidon_hash.go), which returns only the first element of the three elements state. I had to make some modifications inside and can't use it as a package rn. Is it ok to leave this copy-pasted code, or should I come up with sth else |
@MaksymMalicki can i start reviewing it as the final version? |
@TAdev0 yeah sure, just don't review the poseidon hash math itself, as I'm going to remove it entirely, once the new release of Juno with updated crypto package is out |
ok got it will review today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems alll good for me! I approve and lets wait for Juno to release the new function so that you can import PoseidonPerm
directly
No description provided.