From ab921f950d1c62de245a43522b9065aa411cebd4 Mon Sep 17 00:00:00 2001 From: "lukasz.rozmej" Date: Wed, 13 Dec 2023 22:08:28 +0100 Subject: [PATCH] Revert "overload instead of override" This reverts commit 27c36863e82cd75b6c327da2d101e730f69724cd. --- .../Data/ExecutionPayload.cs | 4 ++-- .../Data/ExecutionPayloadV3.cs | 16 ++++------------ 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayload.cs b/src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayload.cs index 81a3553220a..cedac0264f8 100644 --- a/src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayload.cs +++ b/src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayload.cs @@ -97,14 +97,14 @@ public byte[][] Transactions /// EIP-4844. /// [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] - public ulong? BlobGasUsed { get; set; } + public virtual ulong? BlobGasUsed { get; set; } /// /// Gets or sets as defined in /// EIP-4844. /// [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] - public ulong? ExcessBlobGas { get; set; } + public virtual ulong? ExcessBlobGas { get; set; } /// /// Gets or sets as defined in diff --git a/src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayloadV3.cs b/src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayloadV3.cs index e4f8f477e91..ff236bab63d 100644 --- a/src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayloadV3.cs +++ b/src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayloadV3.cs @@ -18,8 +18,8 @@ public class ExecutionPayloadV3 : ExecutionPayload public ExecutionPayloadV3(Block block) : base(block) { ParentBeaconBlockRoot = block.ParentBeaconBlockRoot; - base.BlobGasUsed = block.BlobGasUsed; - base.ExcessBlobGas = block.ExcessBlobGas; + BlobGasUsed = block.BlobGasUsed; + ExcessBlobGas = block.ExcessBlobGas; } public override bool TryGetBlock(out Block? block, UInt256? totalDifficulty = null) @@ -43,20 +43,12 @@ public override bool TryGetBlock(out Block? block, UInt256? totalDifficulty = nu /// EIP-4844. /// [JsonRequired] - public new ulong BlobGasUsed - { - get => base.BlobGasUsed ?? 0; - set => base.BlobGasUsed = value; - } + public override ulong? BlobGasUsed { get; set; } /// /// Gets or sets as defined in /// EIP-4844. /// [JsonRequired] - public new ulong ExcessBlobGas - { - get => base.ExcessBlobGas ?? 0; - set => base.ExcessBlobGas = value; - } + public override ulong? ExcessBlobGas { get; set; } }