Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't make mainnet.cfg the default #4289

Closed
dceleda opened this issue Jul 18, 2022 · 10 comments
Closed

Don't make mainnet.cfg the default #4289

dceleda opened this issue Jul 18, 2022 · 10 comments
Assignees

Comments

@dceleda
Copy link
Contributor

dceleda commented Jul 18, 2022

Describe the bug
We've introduced an unexpected breaking change in 1.13.4:
In case you do not use your own configuration file, mainnet.cfg settings are used by default and since the update, SnapSync is enabled by default for the mainnet configuration, which means it's enabled for your node too.
It will cause a problem in networks without SnapSync supporting nodes.

Expected behavior
Nodes without a config file shouldn't use the mainnet.cfg file as a default.

@dceleda
Copy link
Contributor Author

dceleda commented Jul 18, 2022

Maybe we should introduce a default.cfg based on the mainnet.cfg just not to break the current behavior?

@MarekM25
Copy link
Contributor

MarekM25 commented Jul 18, 2022

The similar problem: #4282 Pruning.None for archive nodes

@LukaszRozmej
Copy link
Member

Not sure how this would solve any issues?

@smartprogrammer93 smartprogrammer93 removed their assignment Oct 3, 2022
@kamilchodola
Copy link
Contributor

@dceleda @smartprogrammer93 @LukaszRozmej @MarekM25
I don't get it TBH
When someone runs Nethermind.Runner without config then is supposed to run Nethermind on mainnet. I don't get a part with "in networks without SnapSync" - how this can be reproduced?

@dceleda
Copy link
Contributor Author

dceleda commented Dec 1, 2022

@dceleda @smartprogrammer93 @LukaszRozmej @MarekM25 I don't get it TBH When someone runs Nethermind.Runner without config then is supposed to run Nethermind on mainnet. I don't get a part with "in networks without SnapSync" - how this can be reproduced?

#4281

@smartprogrammer93
Copy link
Contributor

I believe the whole idea behind this issue and PR is obselete. It was in the early days of SnapSync when suddenly in the mainnet config snapsync became on by default. Which broke some nodes that have not synced using snapSync. But i think it is now too late to introduce this change

@dceleda
Copy link
Contributor Author

dceleda commented Dec 1, 2022

I believe the whole idea behind this issue and PR is obselete. It was in the early days of SnapSync when suddenly in the mainnet config snapsync became on by default. Which broke some nodes that have not synced using snapSync. But i think it is now too late to introduce this change

Does it mean that the mainnet config is not the default one anymore and whenever we introduce a change to that file it won't affect custom networks without a config file?
As for my understanding, the SnapSync case was just an example of what can go wrong in such scenario.

@smartprogrammer93
Copy link
Contributor

smartprogrammer93 commented Dec 1, 2022

No mainnet config is still the default. Its just that all private network probably upgraded and adjusted to the change. The change to snapsync being on by default was introduced months ago. So i dont think it is important to revert it by default now. Furthermore, this might break existing setups where they do not specify mainnet config and expect snap to be on

@dceleda
Copy link
Contributor Author

dceleda commented Dec 1, 2022

To be honest it looks like a broken feature/bug - to use the mainnet config as the default one. But since the last problem (SnapSync config change), we haven't faced any new ones so maybe we should just close the item.?
WDYT

@marcindsobczak
Copy link
Contributor

IMO changing default config to default.cfg which is mainnet without snap sync is a very problematic solution - many users will unconsciously run it and be frustrated by sync time. We will have a lot of new, syncing nodes (and maybe even with never-ending sync), we can scare many new users because of that. Every network has it's own config file with proper setup. If user is trying to run network which doesn't have config file, then there is a need to create proper one and user have e.g. discord to ask for help with that, or can create an issue here in case of any troubles. I think we have way more mainnet users than ones trying to run private networks and I expect the second ones to be more technically advanced and able to prepare proper config. We are ethereum client and IMO it's fine to have ethereum mainnet config as default one and make usage of Nethermind as mainnet client as easy as possible

@dceleda dceleda closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants