Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Erigon Execution Client #156

Merged
merged 21 commits into from Dec 3, 2022
Merged

Add Erigon Execution Client #156

merged 21 commits into from Dec 3, 2022

Conversation

stdevMac
Copy link
Member

@stdevMac stdevMac commented Nov 3, 2022

Changes:

  • Add erigon Execution client to stack

Types of changes

What types of changes does your code introduce?

  • New feature (non-breaking change which adds functionality)

Testing

  • Yes
    In case you checked yes, did you write tests?

  • Yes

  • No

Comments about testing , should you have some (optional)
Run smoke tests

@stdevMac stdevMac added the enhancement New feature or request label Nov 3, 2022
@stdevMac stdevMac self-assigned this Nov 3, 2022
@AntiD2ta AntiD2ta changed the title Add Erigon Execution wxxxxxxx Add Erigon Execution Client Nov 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Base: 80.49% // Head: 80.49% // No change to project coverage 👍

Coverage data is based on head (64c57fb) compared to base (3625b47).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #156   +/-   ##
========================================
  Coverage    80.49%   80.49%           
========================================
  Files           40       40           
  Lines         2517     2517           
========================================
  Hits          2026     2026           
  Misses         406      406           
  Partials        85       85           
Flag Coverage Δ
unittests 80.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update /scripts/check-image-updates.sh with Erigon, so we can get the latest release from Erigon as soon as possible. The rest is very good apart from minor changes requested in the erigon service template.

templates/services/merge/execution/erigon.tmpl Outdated Show resolved Hide resolved
templates/services/merge/execution/erigon.tmpl Outdated Show resolved Hide resolved
@stdevMac
Copy link
Member Author

stdevMac commented Nov 7, 2022

@AntiD2ta just solved what you requested, please review it again!

@AntiD2ta AntiD2ta merged commit 93d340f into develop Dec 3, 2022
@AntiD2ta AntiD2ta deleted the feature/add-erigon branch December 3, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants