bridge: test connection.autoconnect-slaves behavior #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoconnect.slaves should forcefully activate all slaves, even if the device is currently busy with another profile. That was the case already, but slightly broken with [1]. This adds two tests, one a general test, and the other where the profile that should be stolen for activation is the slave profile itself, but activated previously as a non-slave before being modified. This is the scenario of bug [2]. [1] https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=0922a177385be188b9c9c8ad39c1068533f5a4b3 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1548265
|
Vladimir, please squash the last 2 commits into the first before merging. |
Disable STP so that the bridge links goes up immediately when a slave is up. Also, modify the second test so that the bridge is autoactivated because the fix for bz 1548265 is needed only for autoactivations.
bengal
force-pushed
the
th/autoconnect-slaves-rh1548265
branch
from
3094c72
to
2d63c1f
Compare
vbenes
force-pushed
the
th/autoconnect-slaves-rh1548265
branch
from
2d63c1f
to
8b88e45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoconnect.slaves should forcefully activate all slaves, even if the
device is currently busy with another profile. That was the case already,
but slightly broken with [1].
This adds two tests, one a general test, and the other where the
profile that should be stolen for activation is the slave profile
itself, but activated previously as a non-slave before being modified.
This is the scenario of bug [2].
[1] https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=0922a177385be188b9c9c8ad39c1068533f5a4b3
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1548265
The second test is not yet expected to pass on master, which is what [2] is all about.