Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lr/modemu-ppc64: contrib/modemu.pl fixes for IBM POWER #246

Merged
merged 3 commits into from Nov 7, 2018

Conversation

@lkundrak
Copy link
Member

commented Nov 6, 2018

In light of recent events, we're deprecating x86.

@bengal

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

LGTM

@fgiudici

This comment has been minimized.

Copy link
Member

commented Nov 7, 2018

ACK

lkundrak added 3 commits Nov 6, 2018
Required by Fedora Packaging Standards [1] and also really useful.

[1] https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries#Requirement_if_you_bundle

#247
Tested on a really really big endian IBM POWER. Also turn an accompanying
comment into a slightly more sensible one.

#246
This allows us to somehow work with no PCI (or USB for that matter), such
as some virtual machines. Old ModemManager doesn't like this though, but
there doesn't seem to be a way around it.

#246
@lkundrak lkundrak force-pushed the lkundrak:lr/modemu-ppc64 branch from 0d6b381 to 32857a0 Nov 7, 2018
@lkundrak lkundrak merged commit 32857a0 into NetworkManager:master Nov 7, 2018
0 of 3 checks passed
0 of 3 checks passed
NetworkManager CI NetworkManager CI job has started
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
semaphoreci The build is pending on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.